Re: [BUG] redundant error message

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 5, 2013, 21:44 UTC
Message-ID: <xmqq8uvz3rdf.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20131205212851.GA21776@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 13 quoted lines

> BTW, the raw looping to find "--" made me wonder how we handle:
>
>   git log --grep -- HEAD
>
> I'd expect it to be equivalent to:
>
>   git log --grep=-- HEAD
>
> but it's not; we truncate the arguments and complain that --grep is
> missing its argument. Which is probably good enough, given that the
> alternative is doing a pass that understands all of the options. But it
> does mean that the "--long-opt=arg" form is safer than the split form if
> you are passing along an arbitrary "arg".

;-) Good flow of thought. As to your rev-parse change, I don't immediately think of a hole/flaw offhand; it looked a good straight-forward change to me.