Re: [BUG] redundant error message

From: Jeff King <peff@peff.net>
Date: Dec 5, 2013, 19:15 UTC
Message-ID: <20131205191518.GB19039@sigill.intra.peff.net>
In-Reply-To: <CACsJy8BtCi_QSMZXfnscQmRyjvgSV1fG6smAOoCSab_e2YATxQ@mail.gmail.com>

On Thu, Dec 05, 2013 at 05:07:31PM +0700, Duy Nguyen wrote:

Show 8 quoted lines

> $ git rev-parse foobar --
> foobar
> fatal: ambiguous argument 'foobar': unknown revision or path not in
> the working tree.
> Use '--' to separate paths from revisions, like this:
> 'git <command> [<revision>...] -- [<file>...]'
> 
> I already put "--" there. So it should shut up.

I think it is more than just a bad error message; if we get that message, it means we are following the wrong code path in interpreting "foobar":

  $ >foobar
  $ git rev-parse foobar --
  foobar
  --
  fatal: bad flag '--' used after filename

That's not right. It looks like this isn't a new breakage, though. v1.5.0 produces the same result.

-Peff