Re: [PATCH v2 0/3] rev-parse and "--"

From: Jeff King <peff@peff.net>
Date: Dec 6, 2013, 23:30 UTC
Message-ID: <20131206233004.GA29524@sigill.intra.peff.net>
In-Reply-To: <20131206232556.GN29959@google.com>

On Fri, Dec 06, 2013 at 03:25:56PM -0800, Jonathan Nieder wrote:

Show 9 quoted lines

> >   commit=$(git rev-parse HEAD)
> >
> > I'm tempted to say that people who did that are stupid and wrong (and
> > ugly, too). They should probably be using "--verify" in this case. But
> > it has been that way for a long time, and there are two instances in our
> > test scripts that are broken by the patch.
> 
> Wouldn't the same thing happen for $(git rev-parse HEAD^..HEAD) when
> there is a 'HEAD^..HEAD' file, too?  --verify doesn't support that.

True, but they can use "rev-parse HEAD^..HEAD --", which is probably a better alternative to --verify.

> I think it's a nice idea to provide this functionality for people who
> need it, which would mean protected by an option (--check-ambiguity or
> something).  I don't think it's a good change to do it
> unconditionally.

I don't think it's worth making it conditional. Literally nobody has asked for it. I was mostly trying to harmonize "rev-parse" and the rest of the revision parser. If that's not worth doing, I'd just as soon drop it (and people using "--" properly already get the right behavior).

-Peff