Re: [BUG] redundant error message

From: Jeff King <peff@peff.net>
Date: Dec 5, 2013, 20:03 UTC
Message-ID: <20131205200306.GA13443@sigill.intra.peff.net>
In-Reply-To: <xmqqsiu73w6n.fsf@gitster.dls.corp.google.com>

On Thu, Dec 05, 2013 at 12:00:16PM -0800, Junio C Hamano wrote:

Show 16 quoted lines

> Jeff King <peff@peff.net> writes:
> 
> >   $ >foobar
> >   $ git rev-parse foobar --
> >   foobar
> >   --
> >   fatal: bad flag '--' used after filename
> >
> > That's not right.
> 
> Hmph, it looks like it is following the usual "zero-or-more dashed
> options, zero-or-more revs and then zero-or-one double-dash and then
> zero-or-more paths" rule to parse the thing.  "foobar" is a file and
> not a rev, so "--" should not be there, no?
> 
> Confused why you think it is not right...

Because once you say "--", then all ambiguity goes away, no? Everything to the left is a rev, not a filename, and everything to the right is a filename. E.g.:

  $ git log foobar --
  fatal: bad revision 'foobar'

I think rev-parse is not following the same rules that the rest of the revision-parsing programs do.

-Peff