git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 5/8] t1308: relax the test verifying that empty alias values are disallowed

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 13, 2017, 12:59 UTC
Message-ID
<xmqq8tkw9h7p.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<alpine.DEB.2.21.1.1706131244150.171564@virtualbox>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> Sadly, I do not think so. It is just different, not better. Maybe less
> redundant... See for yourself:

Yup, I noticed and was referring to this "less redundant" as an improvement, actually.

> The real fix would indeed be (as mentioned by Brandon elsewhere) to unify
> the code paths between the cached and the non-cached config machinery, so
> as to provide the exact same error message in this case.

Yeah, the unifying of the messages would be a good addition in the mid term but I tend to agree that it can be done after this series lands.

Thanks for clarification.
Previous: Johannes SchindelinNext: Johannes Schindelin
Message 15 of 32 in “Avoid problem where git_dir is set after alias expansion”
  1. 0/8 Avoid problem where git_dir is set after alias expansionJohannes Schindelin, Jun 8, 2017
  2. 2/8 config: report correct line number upon errorJohannes Schindelin, Jun 8, 2017
  3. Jeff KingJun 10, 2017
  4. Johannes SchindelinJun 13, 2017
  5. Jeff KingJun 13, 2017
  6. 4/8 read_early_config(): optionally return the worktree's top-level directoryJohannes Schindelin, Jun 8, 2017
  7. Jeff KingJun 10, 2017
  8. 1/8 discover_git_directory(): avoid setting invalid git_dirJohannes Schindelin, Jun 8, 2017
  9. Jeff KingJun 10, 2017
  10. 3/8 help: use early config when autocorrecting aliasesJohannes Schindelin, Jun 8, 2017
  11. Jeff KingJun 10, 2017
  12. 5/8 t1308: relax the test verifying that empty alias values are disallowedJohannes Schindelin, Jun 8, 2017
  13. Junio C HamanoJun 10, 2017
  14. Johannes SchindelinJun 13, 2017
  15. Junio C HamanoJun 13, 2017
  16. 6/8 t7006: demonstrate a problem with aliases in subdirectoriesJohannes Schindelin, Jun 8, 2017
  17. 8/8 Use the early config machinery to expand aliasesJohannes Schindelin, Jun 8, 2017
  18. Jeff KingJun 10, 2017
  19. Jeff KingJun 10, 2017
  20. Junio C HamanoJun 12, 2017
  21. Johannes SchindelinJun 13, 2017
  22. Jeff KingJun 13, 2017
  23. 7/8 alias_lookup(): optionally return top-level directoryJohannes Schindelin, Jun 8, 2017
  24. Jeff KingJun 10, 2017
  25. Johannes SchindelinJun 13, 2017
  26. Jeff KingJun 13, 2017
  27. Johannes SchindelinJun 13, 2017
  28. Jeff KingJun 13, 2017
  29. Junio C HamanoJun 13, 2017
  30. Jeff KingJun 14, 2017
  31. Johannes SchindelinJun 14, 2017
  32. Brandon WilliamsJun 8, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.