git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/8] Avoid problem where git_dir is set after alias expansion

From
BWBrandon Williams <bmwill@google.com>
Date
Jun 8, 2017, 22:32 UTC
Message-ID
<20170608223237.GB121539@google.com>
In-Reply-To
<cover.1496951503.git.johannes.schindelin@gmx.de>
On 06/08, Johannes Schindelin wrote:
Show 15 quoted lines
> 
> Changes since v1:
> 
> - 1/8's commit message clarifies why the other early return in
>   discover_git_directory() does not need an equivalent resetting of
>   git_dir.
> 
> - 3/8's commit message fixes awkward language (thanks, Brandon!).
> 
> - the `worktree_dir` variables/parameters have been renamed to
>   `cdup_dir` to clarify that they only get populated if the search for
>   the .git/ directory determined that the current working directory
>   is a subdirectory of the directory containing .git/.
> 
> 

v2 addresses some of the comments I had with v1, so everything looks good to me.

Show 23 quoted lines
> Johannes Schindelin (8):
>   discover_git_directory(): avoid setting invalid git_dir
>   config: report correct line number upon error
>   help: use early config when autocorrecting aliases
>   read_early_config(): optionally return the worktree's top-level
>     directory
>   t1308: relax the test verifying that empty alias values are disallowed
>   t7006: demonstrate a problem with aliases in subdirectories
>   alias_lookup(): optionally return top-level directory
>   Use the early config machinery to expand aliases
> 
>  alias.c                | 33 +++++++++++++++++++++-------
>  builtin/help.c         |  2 +-
>  cache.h                |  7 +++---
>  config.c               |  7 +++---
>  git.c                  | 59 ++++++--------------------------------------------
>  help.c                 |  2 +-
>  pager.c                |  4 ++--
>  setup.c                | 13 +++++++++--
>  t/helper/test-config.c |  2 +-
>  t/t1308-config-set.sh  |  4 +++-
>  t/t7006-pager.sh       | 11 ++++++++++
>  11 files changed, 70 insertions(+), 74 deletions(-)
-- 
Brandon Williams
Previous: Johannes Schindelin
Message 32 of 32 in “Avoid problem where git_dir is set after alias expansion”
  1. 0/8 Avoid problem where git_dir is set after alias expansionJohannes Schindelin, Jun 8, 2017
  2. 2/8 config: report correct line number upon errorJohannes Schindelin, Jun 8, 2017
  3. Jeff KingJun 10, 2017
  4. Johannes SchindelinJun 13, 2017
  5. Jeff KingJun 13, 2017
  6. 4/8 read_early_config(): optionally return the worktree's top-level directoryJohannes Schindelin, Jun 8, 2017
  7. Jeff KingJun 10, 2017
  8. 1/8 discover_git_directory(): avoid setting invalid git_dirJohannes Schindelin, Jun 8, 2017
  9. Jeff KingJun 10, 2017
  10. 3/8 help: use early config when autocorrecting aliasesJohannes Schindelin, Jun 8, 2017
  11. Jeff KingJun 10, 2017
  12. 5/8 t1308: relax the test verifying that empty alias values are disallowedJohannes Schindelin, Jun 8, 2017
  13. Junio C HamanoJun 10, 2017
  14. Johannes SchindelinJun 13, 2017
  15. Junio C HamanoJun 13, 2017
  16. 6/8 t7006: demonstrate a problem with aliases in subdirectoriesJohannes Schindelin, Jun 8, 2017
  17. 8/8 Use the early config machinery to expand aliasesJohannes Schindelin, Jun 8, 2017
  18. Jeff KingJun 10, 2017
  19. Jeff KingJun 10, 2017
  20. Junio C HamanoJun 12, 2017
  21. Johannes SchindelinJun 13, 2017
  22. Jeff KingJun 13, 2017
  23. 7/8 alias_lookup(): optionally return top-level directoryJohannes Schindelin, Jun 8, 2017
  24. Jeff KingJun 10, 2017
  25. Johannes SchindelinJun 13, 2017
  26. Jeff KingJun 13, 2017
  27. Johannes SchindelinJun 13, 2017
  28. Jeff KingJun 13, 2017
  29. Junio C HamanoJun 13, 2017
  30. Jeff KingJun 14, 2017
  31. Johannes SchindelinJun 14, 2017
  32. Brandon WilliamsJun 8, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.