Re: [PATCH v2 5/8] t1308: relax the test verifying that empty alias values are disallowed

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 10, 2017, 04:29 UTC
Message-ID: <xmqq37b84g9t.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <b9e212d508e9103037da2070cc0aaed530ea7473.1496951503.git.johannes.schindelin@gmx.de>

Johannes Schindelin <johannes.schindelin@gmx.de> writes:

Show 27 quoted lines

> We are about to change the way aliases are expanded, to use the early
> config machinery.
>
> This machinery reports errors in a slightly different manner than the
> cached config machinery.
>
> Let's not get hung up by the precise wording of the message mentioning
> the lin number. It is really sufficient to verify that all the relevant
> information is given to the user.
>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---
>  t/t1308-config-set.sh | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/t/t1308-config-set.sh b/t/t1308-config-set.sh
> index ff50960ccae..69a0aa56d6d 100755
> --- a/t/t1308-config-set.sh
> +++ b/t/t1308-config-set.sh
> @@ -215,7 +215,9 @@ test_expect_success 'check line errors for malformed values' '
>  		br
>  	EOF
>  	test_expect_code 128 git br 2>result &&
> -	test_i18ngrep "fatal: .*alias\.br.*\.git/config.*line 2" result
> +	test_i18ngrep "missing value for .alias\.br" result &&
> +	test_i18ngrep "fatal: .*\.git/config" result &&
> +	test_i18ngrep "fatal: .*line 2" result

Just judging from the looks of these, it appears that the updated messages are more descriptive than the original. Am I mistaken?

If so I think the log message undersells the changes made by the series by sounding as if you are saying "we are too lazy to bother giving the same message, so here is a workaround".

In any case, s/lin number/line number/ is needed ;-)