git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 3/8] help: use early config when autocorrecting aliases

From
Jeff King <peff@peff.net>
Date
Jun 10, 2017, 09:05 UTC
Message-ID
<20170610090536.zqsiqi72ffpqt2ue@sigill.intra.peff.net>
In-Reply-To
<2be3d75cd3341c1386f97c77cc63bec89c1f6a47.1496951503.git.johannes.schindelin@gmx.de>
On Thu, Jun 08, 2017 at 09:53:38PM +0200, Johannes Schindelin wrote:
Show 21 quoted lines
> Git has this feature which suggests similar commands (including aliases)
> in case the user specified an unknown command.
> 
> This feature currently relies on a side effect of the way we expand
> aliases right now: when a command is not a builtin, we use the regular
> config machinery (meaning: discovering the .git/ directory and
> initializing global state such as the config cache) to see whether the
> command refers to an alias.
> 
> However, we will change the way aliases are expanded in the next
> commits, to use the early config instead. That means that the
> autocorrect feature can no longer discover the available aliases by
> looking at the config cache (because it has not yet been initialized).
> 
> So let's just use the early config machinery instead.
> 
> This is slightly less performant than the previous way, as the early
> config is used *twice*: once to see whether the command refers to an
> alias, and then to see what aliases are most similar. However, this is
> hardly a performance-critical code path, so performance is less important
> here.
Good explanation, and the patch looks obviously correct.
-Peff
Previous: Johannes SchindelinNext: Johannes Schindelin
Message 11 of 32 in “Avoid problem where git_dir is set after alias expansion”
  1. 0/8 Avoid problem where git_dir is set after alias expansionJohannes Schindelin, Jun 8, 2017
  2. 2/8 config: report correct line number upon errorJohannes Schindelin, Jun 8, 2017
  3. Jeff KingJun 10, 2017
  4. Johannes SchindelinJun 13, 2017
  5. Jeff KingJun 13, 2017
  6. 4/8 read_early_config(): optionally return the worktree's top-level directoryJohannes Schindelin, Jun 8, 2017
  7. Jeff KingJun 10, 2017
  8. 1/8 discover_git_directory(): avoid setting invalid git_dirJohannes Schindelin, Jun 8, 2017
  9. Jeff KingJun 10, 2017
  10. 3/8 help: use early config when autocorrecting aliasesJohannes Schindelin, Jun 8, 2017
  11. Jeff KingJun 10, 2017
  12. 5/8 t1308: relax the test verifying that empty alias values are disallowedJohannes Schindelin, Jun 8, 2017
  13. Junio C HamanoJun 10, 2017
  14. Johannes SchindelinJun 13, 2017
  15. Junio C HamanoJun 13, 2017
  16. 6/8 t7006: demonstrate a problem with aliases in subdirectoriesJohannes Schindelin, Jun 8, 2017
  17. 8/8 Use the early config machinery to expand aliasesJohannes Schindelin, Jun 8, 2017
  18. Jeff KingJun 10, 2017
  19. Jeff KingJun 10, 2017
  20. Junio C HamanoJun 12, 2017
  21. Johannes SchindelinJun 13, 2017
  22. Jeff KingJun 13, 2017
  23. 7/8 alias_lookup(): optionally return top-level directoryJohannes Schindelin, Jun 8, 2017
  24. Jeff KingJun 10, 2017
  25. Johannes SchindelinJun 13, 2017
  26. Jeff KingJun 13, 2017
  27. Johannes SchindelinJun 13, 2017
  28. Jeff KingJun 13, 2017
  29. Junio C HamanoJun 13, 2017
  30. Jeff KingJun 14, 2017
  31. Johannes SchindelinJun 14, 2017
  32. Brandon WilliamsJun 8, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.