git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 7/8] alias_lookup(): optionally return top-level directory

From
Jeff King <peff@peff.net>
Date
Jun 13, 2017, 11:29 UTC
Message-ID
<20170613112940.ulkjfchkg6k7xsc5@sigill.intra.peff.net>
In-Reply-To
<alpine.DEB.2.21.1.1706131319130.171564@virtualbox>
On Tue, Jun 13, 2017 at 01:21:28PM +0200, Johannes Schindelin wrote:
Show 15 quoted lines
> > Two optional cleanups here:
> > 
> >   1. We don't need to call config_key_is_valid when using a callback. We
> >      only needed that to prevent the configset machinery from issuing a
> >      warning. It does save us reading the config entirely when the
> >      program name is syntactically invalid as an alias, but that's a
> >      pretty rare case.
> 
> It may be a pretty rare case, or it may not be. I do not want to think
> hard about this, so I just wanted to keep that test.
> 
> But since you suggested it, I will simply blame all the fallout (if any)
> on you.
> 
> ;-)
I accept all the blame. :)

(And I was the person who added the is_valid check here, so I can take both blame and credit for the whole thing).

-Peff
Previous: Johannes SchindelinNext: Johannes Schindelin
Message 26 of 32 in “Avoid problem where git_dir is set after alias expansion”
  1. 0/8 Avoid problem where git_dir is set after alias expansionJohannes Schindelin, Jun 8, 2017
  2. 2/8 config: report correct line number upon errorJohannes Schindelin, Jun 8, 2017
  3. Jeff KingJun 10, 2017
  4. Johannes SchindelinJun 13, 2017
  5. Jeff KingJun 13, 2017
  6. 4/8 read_early_config(): optionally return the worktree's top-level directoryJohannes Schindelin, Jun 8, 2017
  7. Jeff KingJun 10, 2017
  8. 1/8 discover_git_directory(): avoid setting invalid git_dirJohannes Schindelin, Jun 8, 2017
  9. Jeff KingJun 10, 2017
  10. 3/8 help: use early config when autocorrecting aliasesJohannes Schindelin, Jun 8, 2017
  11. Jeff KingJun 10, 2017
  12. 5/8 t1308: relax the test verifying that empty alias values are disallowedJohannes Schindelin, Jun 8, 2017
  13. Junio C HamanoJun 10, 2017
  14. Johannes SchindelinJun 13, 2017
  15. Junio C HamanoJun 13, 2017
  16. 6/8 t7006: demonstrate a problem with aliases in subdirectoriesJohannes Schindelin, Jun 8, 2017
  17. 8/8 Use the early config machinery to expand aliasesJohannes Schindelin, Jun 8, 2017
  18. Jeff KingJun 10, 2017
  19. Jeff KingJun 10, 2017
  20. Junio C HamanoJun 12, 2017
  21. Johannes SchindelinJun 13, 2017
  22. Jeff KingJun 13, 2017
  23. 7/8 alias_lookup(): optionally return top-level directoryJohannes Schindelin, Jun 8, 2017
  24. Jeff KingJun 10, 2017
  25. Johannes SchindelinJun 13, 2017
  26. Jeff KingJun 13, 2017
  27. Johannes SchindelinJun 13, 2017
  28. Jeff KingJun 13, 2017
  29. Junio C HamanoJun 13, 2017
  30. Jeff KingJun 14, 2017
  31. Johannes SchindelinJun 14, 2017
  32. Brandon WilliamsJun 8, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.