Re: [PATCH v3 1/1] clone: report duplicate entries on case-insensitive filesystems

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 13, 2018, 16:55 UTC
Message-ID: <xmqq8t5a6wbc.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <CACsJy8BeRYVvWvTQU+bj+hSQ3DFw0mHtSjtOg9zVSsXznpU=Xw@mail.gmail.com>

Duy Nguyen <pclouds@gmail.com> writes:

> I was careless and checked the wrong variable (should have checked
> nr_duplicates not state.nr_duplicates; the second is a pointer). So we
> always get this warning (and with no following list of files)

Heh, does that bug go away if you got rid of the pointer-ness of the field and store the value directly in there?

>>     I also notice that this patch doesn't add any tests... :)
>
> This is platform specific and I was to be frank a bit lazy. Will
> consider adding a test with CASE_INSENSITIVE_FS after this.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.