Re: [PATCH v3 1/1] clone: report duplicate entries on case-insensitive filesystems

From: Duy Nguyen <pclouds@gmail.com>
Date: Aug 13, 2018, 17:12 UTC
Message-ID: <CACsJy8DudzY7n3XJ4tLKaLWEcA3ctwkzW8amny=KdhP4u2p_8g@mail.gmail.com>
In-Reply-To: <xmqq8t5a6wbc.fsf@gitster-ct.c.googlers.com>

On Mon, Aug 13, 2018 at 6:55 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 9 quoted lines

>
> Duy Nguyen <pclouds@gmail.com> writes:
>
> > I was careless and checked the wrong variable (should have checked
> > nr_duplicates not state.nr_duplicates; the second is a pointer). So we
> > always get this warning (and with no following list of files)
>
> Heh, does that bug go away if you got rid of the pointer-ness of the
> field and store the value directly in there?

You mean replacing the pointer with a real counter in struct checkout? That would not work (it was my first option) because struct checkout is passed around as a const struct. entry.c code is not allowed to make any updates there. So I got rid of both "nr_duplicates" and just count again at the bottom of check_updates(). It's not that expensive and it simplifies the code.

-- 
Duy