Re: [PATCH v5] clone: report duplicate entries on case-insensitive filesystems

From: Ramsay Jones <ramsay@ramsayjones.plus.com>
Date: Nov 19, 2018, 23:29 UTC
Message-ID: <5ffa3a01-8b76-0b84-a21c-efe912e80333@ramsayjones.plus.com>
In-Reply-To: <20181119210323.GA31963@duynguyen.home>

On 19/11/2018 21:03, Duy Nguyen wrote:

Show 5 quoted lines

> First of all, Ramsay, it would be great if you could test the below
> patch and see if it works on Cygwin. I assume since Cygwin shares the
> underlying filesystem, it will share the same "no trusting inode"
> issue with native builds (or it calculates inodes anyway using some
> other source?).

Hmm, I have no idea why you would like me to try this patch - care to explain? [I just saw, "Has this been tested on cygwin?" and, since it has been happily passing for some time, responded yes!]

Just for the giggles, I removed the !CYGWIN prerequisite from the test and when, as expected, the test failed, had a look around:

$ pwd /home/ramsay/git/t/trash directory.t5601-clone $ cat icasefs/warning Cloning into 'bogus'... done. warning: the following paths have collided (e.g. case-sensitive paths on a case-insensitive filesystem) and only one from the same colliding group is in the working tree:

  'x'
$ cd icasefs/bogus
$ ls -l
total 0
-rw-r--r-- 1 ramsay None 0 Nov 19 22:40 x
$ git ls-files --debug
ignoring EOIE extension
X
  ctime: 1542667201:664036600
  mtime: 1542667201:663055400
  dev: 2378432	ino: 324352
  uid: 1001	gid: 513
  size: 0	flags: 0
x
  ctime: 1542667201:665026800
  mtime: 1542667201:665026800
  dev: 2378432	ino: 324352
  uid: 1001	gid: 513
  size: 0	flags: 0
$

So, both X and x are in the index with the same inode number.

Does that help?

ATB, Ramsay Jones