From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 13 Aug 2018 16:55:03 GMT
Subject: Re: [PATCH v3 1/1] clone: report duplicate entries on case-insensitive filesystems
Message-ID: <xmqq8t5a6wbc.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <CACsJy8BeRYVvWvTQU+bj+hSQ3DFw0mHtSjtOg9zVSsXznpU=Xw@mail.gmail.com>

Duy Nguyen <pclouds@gmail.com> writes:

> I was careless and checked the wrong variable (should have checked
> nr_duplicates not state.nr_duplicates; the second is a pointer). So we
> always get this warning (and with no following list of files)

Heh, does that bug go away if you got rid of the pointer-ness of the
field and store the value directly in there?

>>     I also notice that this patch doesn't add any tests... :)
>
> This is platform specific and I was to be frank a bit lazy. Will
> consider adding a test with CASE_INSENSITIVE_FS after this.