Re: [PATCH v4 04/13] dir: fix pattern matching on dirs

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 2, 2021, 00:34 UTC
Message-ID: <xmqq7ddr9z0i.fsf@gitster.g>
In-Reply-To: <kl6lzgqnv2dn.fsf@chooglen-macbookpro.roam.corp.google.com>

Glen Choo <chooglen@google.com> writes:

Show 12 quoted lines

> This patch changes the behavior of .gitignore such that directories are
> now matched by prefix instead of matching exactly.
>
> The failure that we observed is something like the following:
>
> In "a/.gitignore", we have the pattern "git/". We should expect that
> "a/git/foo" to be ignored because "git/" should be matched exactly.
> However, "a/git-foo/bar" is also ignored because "git-foo" matches the
> prefix.
>
> I'll prepare a test case for this as soon as I figure out how to write
> it..

FWIW, reverting this commit (and nothing else) from 'master' does not seem to break any test. That does not necessarily mean much (it may be indicating a gap in the test coverage).