Re: [PATCH v2 01/14] t3705: test that 'sparse_entry' is unstaged

From: Matheus Tavares <matheus.bernardino@usp.br>
Date: Sep 15, 2021, 16:32 UTC
Message-ID: <CAHd-oW59G6MF04aUA-XJewa=0VnqbHenb2khkeO7U9egW_6S4A@mail.gmail.com>
In-Reply-To: <8aefce6254c0bcbbbca909a62d033c74c90f980b.1631453010.git.gitgitgadget@gmail.com>

On Sun, Sep 12, 2021 at 10:23 AM Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com> wrote:

Show 7 quoted lines

>
> From: Derrick Stolee <dstolee@microsoft.com>
>
> The tests in t3705-add-sparse-checkout.sh check to see how 'git add'
> behaves with paths outside the sparse-checkout definition. These
> currently check to see if a given warning is present but not that the
> index is not updated with the sparse entries.

Hmm, I probably missed something, but don't we already check that with the `test_sparse_entry_unchanged` helper? The only test case that we don't call it is 'git add --refresh does not update sparse entries', but we explicitly compare the cached 'mtime' from before and after `git add` there.