Re: [PATCH 09/13] rm: add --sparse option

From: Derrick Stolee <stolee@gmail.com>
Date: Sep 8, 2021, 18:04 UTC
Message-ID: <cb7881d7-754e-05fe-16c3-bf2afac4fb3f@gmail.com>
In-Reply-To: <CAHd-oW5JD56UerW6N18Ap9Dmt9eVyd7dZKUhJR6-hSjzzM0s5A@mail.gmail.com>

On 8/27/2021 5:17 PM, Matheus Tavares Bernardino wrote:

Show 8 quoted lines

> On Tue, Aug 24, 2021 at 6:54 PM Derrick Stolee via GitGitGadget
> <gitgitgadget@gmail.com> wrote:
>>
>> Subject: [PATCH 09/12] rm: add --sparse option
> 
> Maybe mention in the commit message that, for now, rm's --sparse only
> affects entries with the skip_worktree bit set? (Which will be changed
> in the following patch.)

I will expand with these details.

Show 6 quoted lines

>>  test_expect_success 'recursive rm does not remove sparse entries' '
>>         git reset --hard &&
>> -       git sparse-checkout set sub/dir &&
>> +       git sparse-checkout set sub/dir/ &&
> 
> Is this change necessary?

No, it is not. Thanks.

-Stolee