Re: [PATCH 05/13] add: fail when adding an untracked sparse file

From: Matheus Tavares Bernardino <matheus.bernardino@usp.br>
Date: Aug 27, 2021, 22:50 UTC
Message-ID: <CAHd-oW5uzek9Ewdw+jXdw6L9WiwC-xz3O3tRr38HRruB8puDkg@mail.gmail.com>
In-Reply-To: <CAHd-oW7D1jikE5ByS36AjACfSJoZeekLCKzX2MRRfayKwKv=qQ@mail.gmail.com>

On Fri, Aug 27, 2021 at 6:06 PM Matheus Tavares Bernardino <matheus.bernardino@usp.br> wrote:

Show 17 quoted lines

>
> While I was playing with this patch, I did the following:
>
> echo a >a
> echo b >b
> git add .
> git commit -m files
> git sparse-checkout set a
> echo c >c
> git add c
>
> And the last `git add` was successful in adding the untracked `c` file
> which is outside the sparse checkout. I'm not sure if I'm doing
> something wrong, but it seems that `path_in_sparse_checkout()` returns
> UNDECIDED for `c`. Is it because there was no pattern in the list
> explicitly excluding it? And if so, should we consider UNDECIDED as
> NOT_MATCHED for `path_in_sparse_checkout()`?

Please disconsider this, It was my fault indeed. I had applied the patches onto the wrong base. Now I fetched them again but from the GGG tag, and my manual test worked as expected.