Re: [PATCH v2 02/14] t1092: behavior for adding sparse files
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- Sep 12, 2021, 22:17 UTC
- Message-ID
- <87lf415tge.fsf@evledraar.gmail.com>
- In-Reply-To
- <61c23dc59a6e062e073ba3bea135c370a78415aa.1631453010.git.gitgitgadget@gmail.com>
On Sun, Sep 12 2021, Derrick Stolee via GitGitGadget wrote:
> +# NEEDSWORK: This documents current behavior, but is not a desirable > +# behavior (untracked files are handled differently than tracked).
I wonder if a test_expect_failure test would be better for the thing that is the desired behavior, but maybe we don't know what the CLI UI for that would look like yet.
Show 8 quoted lines
> +test_expect_success 'add outside sparse cone' ' > + init_repos && > + > + run_on_sparse mkdir folder1 && > + run_on_sparse ../edit-contents folder1/a && > + run_on_sparse ../edit-contents folder1/newfile && > + test_sparse_match test_must_fail git add folder1/a && > + test_i18ngrep "Disable or modify the sparsity rules" sparse-checkout-err &&
Just "grep" is preferred over "test_i18ngrep" now, the GETTEXT_POISON went away.