Re: [PATCH 3/3] ewah: drop ewah_serialize_native function

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 15, 2018, 18:33 UTC
Message-ID: <xmqq602j293p.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180615175111.GD3067@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 8 quoted lines

> One thing that gave me pause on ripping out more code is that I have
> some bitmap-related patches on my send-to-upstream list, and I wasn't
> sure if they used any of this code. But I checked against your patches,
> and no, this can all go (which makes sense -- my patches are about using
> .bitmap files in more places, so they build at a higher level).
>
> So your patches look good to me, modulo the declarations that Ramsay
> noticed should be removed, too.

I'll queue your 1/3 and 4/3 (without 2&3/3) for now and let Derrick and you handle the removal of unused stuff separately on top, so that the fix-proper can graduate earlier than the rest.

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.