Re: [PATCH 3/3] ewah: drop ewah_serialize_native function
- From
Ramsay Jones <ramsay@ramsayjones.plus.com>
- Date
- Jun 15, 2018, 14:07 UTC
- Message-ID
- <f25c0798-7778-7146-5349-ae2c2fb560dd@ramsayjones.plus.com>
- In-Reply-To
- <afbd5335-ef0d-5ca5-84ab-bdfa8bdc50bb@ramsayjones.plus.com>
On 15/06/18 14:56, Ramsay Jones wrote:
Show 19 quoted lines
> > > On 15/06/18 04:32, Jeff King wrote: >> We don't call this function, and never have. The on-disk >> bitmap format uses network-byte-order integers, meaning that >> we cannot use the native-byte-order format written here. >> >> Let's drop it in the name of simplicity. > > Hmm, if you are in the mood to drop ewah dead code, how about: > > ewah/bitmap.o - bitmap_clear > ewah/bitmap.o - bitmap_each_bit > ewah/ewah_bitmap.o - ewah_and > ewah/ewah_bitmap.o - ewah_and_not > ewah/ewah_bitmap.o - ewah_not > ewah/ewah_bitmap.o - ewah_or > > ... in addition to these *(de)serialize* functions. ;-)
Hmm, I didn't spot it at first, but ewah_serialize() also seems to be unused!
ATB, Ramsay Jones