Re: [PATCH 4/3] ewah: adjust callers of ewah_read_mmap()
- From
Derrick Stolee <stolee@gmail.com>
- Date
- Jun 15, 2018, 11:23 UTC
- Message-ID
- <f6931351-df79-cb76-ee29-c57472a6a201@gmail.com>
- In-Reply-To
- <20180615034442.GA14422@sigill.intra.peff.net>
On 6/14/2018 11:44 PM, Jeff King wrote:
> The return value of ewah_read_mmap() is now an ssize_t, > since we could (in theory) process up to 32GB of data. This > would never happen in practice, but a corrupt or malicious > .bitmap or index file could convince us to do so.
Aside: Why a 32GB limit? Usually I see 32-bit issues limiting by 2 (signed) or 4 GB (unsigned). Is there something specifically in the bitmap format that stops at this size?
Thanks, -Stolee