Re: [PATCH 1/8] ewah/bitmap.c: delete unused 'bitmap_clear()'
- From
Ramsay Jones <ramsay@ramsayjones.plus.com>
- Date
- Jun 15, 2018, 14:46 UTC
- Message-ID
- <f95526b3-0f4f-ccf7-1c31-e7f48a00d1e2@ramsayjones.plus.com>
- In-Reply-To
- <20180615143018.170686-2-dstolee@microsoft.com>
On 15/06/18 15:30, Derrick Stolee wrote:
Show 26 quoted lines
> Reported-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
> ---
> ewah/bitmap.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/ewah/bitmap.c b/ewah/bitmap.c
> index 756bdd050e..d61dc6114a 100644
> --- a/ewah/bitmap.c
> +++ b/ewah/bitmap.c
> @@ -45,14 +45,6 @@ void bitmap_set(struct bitmap *self, size_t pos)
> self->words[block] |= EWAH_MASK(pos);
> }
>
> -void bitmap_clear(struct bitmap *self, size_t pos)
> -{
> - size_t block = EWAH_BLOCK(pos);
> -
> - if (block < self->word_alloc)
> - self->words[block] &= ~EWAH_MASK(pos);
> -}
> -
> int bitmap_get(struct bitmap *self, size_t pos)
> {
> size_t block = EWAH_BLOCK(pos);
> I haven't read all the patches yet, but what about the extern declaration in ewah/ewok.h?
ATB, Ramsay Jones