From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 15 Jun 2018 18:33:14 GMT
Subject: Re: [PATCH 3/3] ewah: drop ewah_serialize_native function
Message-ID: <xmqq602j293p.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180615175111.GD3067@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> One thing that gave me pause on ripping out more code is that I have
> some bitmap-related patches on my send-to-upstream list, and I wasn't
> sure if they used any of this code. But I checked against your patches,
> and no, this can all go (which makes sense -- my patches are about using
> .bitmap files in more places, so they build at a higher level).
>
> So your patches look good to me, modulo the declarations that Ramsay
> noticed should be removed, too.

I'll queue your 1/3 and 4/3 (without 2&3/3) for now and let Derrick
and you handle the removal of unused stuff separately on top, so
that the fix-proper can graduate earlier than the rest.

Thanks.