git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-compat-util: prefer poll.h to sys/poll.h

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 14, 2018, 07:32 UTC
Message-ID
<xmqq5zx0nmgv.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20181114011043.27419-1-congdanhqx@gmail.com>
Đoàn Trần Công Danh  <congdanhqx@gmail.com> writes:
Show 9 quoted lines
> -#ifndef NO_SYS_POLL_H
> +#if !defined(NO_POLL_H)
> +#include <poll.h>
> +#elif !defined(NO_SYS_POLL_H)
>  #include <sys/poll.h>
>  #else
> +/* Pull the compat stuff */
>  #include <poll.h>
>  #endif

The last comment would help readers who got "Huh? When NO_POLL_H and NO_SYS_POLL_H is given, we still include <poll.h>" without it.

Looks good.  Thanks.
Previous: Danh Doan
Message 5 of 5 in “git-compat-util: prefer poll.h to sys/poll.h”
  1. git-compat-util: prefer poll.h to sys/poll.hĐoàn Trần Công Danh, Nov 14, 2018
  2. brian m. carlsonNov 14, 2018
  3. Junio C HamanoNov 14, 2018
  4. Danh DoanNov 14, 2018
  5. Junio C HamanoNov 14, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.