git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-compat-util: prefer poll.h to sys/poll.h

From
Danh Doan <congdanhqx@gmail.com>
Date
Nov 14, 2018, 05:32 UTC
Message-ID
<87h8gkrzpu.fsf@congdanhqx.xyz>
In-Reply-To
<20181114014307.GM890086@genre.crustytoothpaste.net>
"brian m. carlson" <sandals@crustytoothpaste.net> writes:
Show 7 quoted lines
>> - t1308.23 is failing because musl `fopen` is success when open directory
>> in readonly mode. POSIX allows this behavior:
>> http://pubs.opengroup.org/onlinepubs/7908799/xsh/fopen.html
>> [EISDIR]
>> The named file is a directory and mode requires write access.
>
> Does setting FREAD_READS_DIRECTORIES fix this?

Yes, setting FREAD_READS_DIRECTORIES fixes this. And, `configure` can set that itself.

I blindly followed the Void's build template which explicitly unset it in the configure script without investigating it. My bad!

I'll send them a patch to fix this downstream.
> -- 
> brian m. carlson: Houston, Texas, US
> OpenPGP: https://keybase.io/bk2204
-- 
Danh
Previous: Junio C HamanoNext: Junio C Hamano
Message 4 of 5 in “git-compat-util: prefer poll.h to sys/poll.h”
  1. git-compat-util: prefer poll.h to sys/poll.hĐoàn Trần Công Danh, Nov 14, 2018
  2. brian m. carlsonNov 14, 2018
  3. Junio C HamanoNov 14, 2018
  4. Danh DoanNov 14, 2018
  5. Junio C HamanoNov 14, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.