Re: [PATCH] git-compat-util: prefer poll.h to sys/poll.h

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 14, 2018, 04:48 UTC
Message-ID: <xmqqr2fop8lr.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20181114014307.GM890086@genre.crustytoothpaste.net>

"brian m. carlson" <sandals@crustytoothpaste.net> writes:

Show 14 quoted lines

> On Wed, Nov 14, 2018 at 08:10:43AM +0700, Đoàn Trần Công Danh wrote:
>> POSIX specifies that <poll.h> is the correct header for poll(2)
>> whereas <sys/poll.h> is only needed for some old libc.
>> 
>> Let's follow the POSIX way by default.
>> 
>> This effectively eliminates musl's warning:
>> 
>>     warning redirecting incorrect #include <sys/poll.h> to <poll.h>
>> 
>> Signed-off-by: Đoàn Trần Công Danh <congdanhqx@gmail.com>
>
> I think this patch is fine.  This was in SUSv2, and I don't feel bad
> about siding with a spec that's at least 17 years old.

Yup, I agree.  Thanks, both.