From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 14 Nov 2018 07:32:16 GMT
Subject: Re: [PATCH] git-compat-util: prefer poll.h to sys/poll.h
Message-ID: <xmqq5zx0nmgv.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20181114011043.27419-1-congdanhqx@gmail.com>

Đoàn Trần Công Danh  <congdanhqx@gmail.com> writes:

> -#ifndef NO_SYS_POLL_H
> +#if !defined(NO_POLL_H)
> +#include <poll.h>
> +#elif !defined(NO_SYS_POLL_H)
>  #include <sys/poll.h>
>  #else
> +/* Pull the compat stuff */
>  #include <poll.h>
>  #endif

The last comment would help readers who got "Huh?  When NO_POLL_H
and NO_SYS_POLL_H is given, we still include <poll.h>" without it.

Looks good.  Thanks.