Re: [PATCH] git-compat-util: prefer poll.h to sys/poll.h

From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Nov 14, 2018, 01:43 UTC
Message-ID: <20181114014307.GM890086@genre.crustytoothpaste.net>
In-Reply-To: <20181114011043.27419-1-congdanhqx@gmail.com>

On Wed, Nov 14, 2018 at 08:10:43AM +0700, Đoàn Trần Công Danh wrote:

Show 10 quoted lines

> POSIX specifies that <poll.h> is the correct header for poll(2)
> whereas <sys/poll.h> is only needed for some old libc.
> 
> Let's follow the POSIX way by default.
> 
> This effectively eliminates musl's warning:
> 
>     warning redirecting incorrect #include <sys/poll.h> to <poll.h>
> 
> Signed-off-by: Đoàn Trần Công Danh <congdanhqx@gmail.com>

I think this patch is fine. This was in SUSv2, and I don't feel bad about siding with a spec that's at least 17 years old.

Show 6 quoted lines

> t0028, t1308.23, t3900.34 is failing under musl,
> Those test cases in question also fails without this patch.
> 
> - t0028 is failing because musl `iconv` output UTF-16 without BOM.
> I'm not sure if my installation is broken, or it's musl's default behavior.
> But, I think RFC2781, section 4.3 allows the missing BOM

While the spec may allow this, we cannot for practical reasons. There are a large number of broken Windows programs that don't honor the spec when it says to interpret UTF-16 byte sequences without a BOM as big-endian, and instead use little-endian. Since we cannot fix all the broken Windows programs people use, we need to emit the BOM in UTF-16 mode.

Show 5 quoted lines

> - t1308.23 is failing because musl `fopen` is success when open directory
> in readonly mode. POSIX allows this behavior:
> http://pubs.opengroup.org/onlinepubs/7908799/xsh/fopen.html
> [EISDIR]
> The named file is a directory and mode requires write access.

Does setting FREAD_READS_DIRECTORIES fix this?

-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204