Re: [PATCH 2/5] refs: make `is_pseudoref_syntax()` stricter
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 23, 2024, 17:38 UTC
- Message-ID
- <xmqq5xzkosqc.fsf@gitster.g>
- In-Reply-To
- <ba721840-7b67-4822-8046-c0da4d3b9bde@gmail.com>
Phillip Wood <phillip.wood123@gmail.com> writes:
> I not sure I quite understand what you mean here. Are you saying that > scripts should stop using "git update-ref" and "git rev-parse" for > anything that does not match the new pseudoref syntax?
Yes, I am saying that, and also that we should have been stricter on what we accept and consider as pseudorefs---not just any file that sits directly under $GIT_DIR/., but ideally we should have limited to "^[A-Z]*_HEAD$" or something. The idea I am floating is to see if such a tightening can be done now without hearing too many screams.