git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 0/4] for-each-ref: print all refs on empty string pattern

From
Karthik Nayak <karthik.188@gmail.com>
Date
Jan 29, 2024, 11:35 UTC
Message-ID
<20240129113527.607022-1-karthik.188@gmail.com>
In-Reply-To
<20240119142705.139374-1-karthik.188@gmail.com>

This is the second version of my patch series to print refs when and empty string pattern is used with git-for-each-ref(1).

With the upcoming introduction of the reftable backend, it becomes ever so important to provide the necessary tooling for printing all refs associated with a repository.

While regular refs stored within the "refs/" namespace are currently supported by multiple commands like git-for-each-ref(1), git-show-ref(1). Neither support printing all the operational refs within the repository.

This is crucial because with the reftable backend, all these refs will also move to reftable. It would be necessary to identify all the refs that are stored within the reftable since there is no easy way to do so otherwise. This is because the reftable itself is a binary format and all access will be via git. Unlike the filesystem backend, which allows access directly via the filesystem.

This patch series is a follow up to the RFC/discussion we had earlier on the list [1].

The first 4 commits add the required functionality to ensure we can print all refs (regular, pseudo, HEAD). The 5th commit modifies the git-for-each-ref(1) command to print all refs when an empty string pattern is used. This is a deviation from the current situation wherein the empty string pattern currently matches and prints no refs.

[1]: https://lore.kernel.org/git/20231221170715.110565-1-karthik.188@gmail.com/#t
Changes since v1:
- Added missing comma to the end of the `irregular_pseudorefs` array.
- Modified `is_pseudoref` to only work with non symrefs.  
Range-diff against v2:
1:  116d4c0e6d ! 1:  2141a2a62b refs: introduce `is_pseudoref()` and `is_headref()`
    @@ refs.c: static int is_pseudoref_syntax(const char *refname)
     +		"BISECT_EXPECTED_REV",
     +		"NOTES_MERGE_PARTIAL",
     +		"NOTES_MERGE_REF",
    -+		"MERGE_AUTOSTASH"
    ++		"MERGE_AUTOSTASH",
     +	};
    ++	struct object_id oid;
     +	size_t i;
     +
     +	if (!is_pseudoref_syntax(refname))
     +		return 0;
     +
    -+	if (ends_with(refname, "_HEAD"))
    -+		return refs_ref_exists(refs, refname);
    ++	if (ends_with(refname, "_HEAD")) {
    ++		 read_ref_full(refname, RESOLVE_REF_READING | RESOLVE_REF_NO_RECURSE,
    ++		      &oid, NULL);
    ++		 return !is_null_oid(&oid);
    ++	}
     +
     +	for (i = 0; i < ARRAY_SIZE(irregular_pseudorefs); i++)
    -+		 if (!strcmp(refname, irregular_pseudorefs[i]))
    -+			 return refs_ref_exists(refs, refname);
    ++		if (!strcmp(refname, irregular_pseudorefs[i])) {
    ++			read_ref_full(refname, RESOLVE_REF_READING | RESOLVE_REF_NO_RECURSE,
    ++						  &oid, NULL);
    ++			return !is_null_oid(&oid);
    ++		}
     +
     +	return 0;
     +}
2:  4d4ca1cb26 = 2:  c96f0a9c83 refs: extract out `loose_fill_ref_dir_regular_file()`
3:  a5c0c4bf31 = 3:  d165358b83 refs: introduce `refs_for_each_all_refs()`
4:  a1c6537815 = 4:  a17983d0ba for-each-ref: avoid filtering on empty pattern
Karthik Nayak (4):
  refs: introduce `is_pseudoref()` and `is_headref()`
  refs: extract out `loose_fill_ref_dir_regular_file()`
  refs: introduce `refs_for_each_all_refs()`
  for-each-ref: avoid filtering on empty pattern
 Documentation/git-for-each-ref.txt |   3 +-
 builtin/for-each-ref.c             |  21 ++++-
 ref-filter.c                       |  13 ++-
 ref-filter.h                       |   4 +-
 refs.c                             |  46 +++++++++++
 refs.h                             |   9 ++
 refs/files-backend.c               | 127 +++++++++++++++++++++--------
 refs/refs-internal.h               |   7 ++
 t/t6302-for-each-ref-filter.sh     |  34 ++++++++
 9 files changed, 225 insertions(+), 39 deletions(-)
-- 
2.43.GIT
Previous: Karthik NayakNext: Karthik Nayak
Message 33 of 94 in “for-each-ref: print all refs on empty string pattern”
  1. 0/5 for-each-ref: print all refs on empty string patternKarthik Nayak, Jan 19, 2024
  2. 1/5 refs: expose `is_pseudoref_syntax()`Karthik Nayak, Jan 19, 2024
  3. Junio C HamanoJan 19, 2024
  4. Karthik NayakJan 22, 2024
  5. 2/5 refs: make `is_pseudoref_syntax()` stricterKarthik Nayak, Jan 19, 2024
  6. Junio C HamanoJan 19, 2024
  7. Phillip WoodJan 22, 2024
  8. Junio C HamanoJan 22, 2024
  9. Phillip WoodJan 23, 2024
  10. Karthik NayakJan 23, 2024
  11. phillip.wood123@gmail.comJan 23, 2024
  12. Junio C HamanoJan 23, 2024
  13. Junio C HamanoJan 23, 2024
  14. Patrick SteinhardtJan 23, 2024
  15. Phillip WoodJan 23, 2024
  16. Junio C HamanoJan 23, 2024
  17. Patrick SteinhardtJan 24, 2024
  18. 3/5 refs: extract out `loose_fill_ref_dir_regular_file()`Karthik Nayak, Jan 19, 2024
  19. 4/5 refs: introduce `refs_for_each_all_refs()`Karthik Nayak, Jan 19, 2024
  20. Junio C HamanoJan 19, 2024
  21. Karthik NayakJan 22, 2024
  22. Junio C HamanoJan 22, 2024
  23. 5/5 for-each-ref: avoid filtering on empty patternKarthik Nayak, Jan 19, 2024
  24. 0/4 for-each-ref: print all refs on empty string patternKarthik Nayak, Jan 24, 2024
  25. 1/4 refs: introduce `is_pseudoref()` and `is_headref()`Karthik Nayak, Jan 24, 2024
  26. Junio C HamanoJan 24, 2024
  27. Karthik NayakJan 25, 2024
  28. Junio C HamanoJan 25, 2024
  29. Karthik NayakJan 25, 2024
  30. 2/4 refs: extract out `loose_fill_ref_dir_regular_file()`Karthik Nayak, Jan 24, 2024
  31. 3/4 refs: introduce `refs_for_each_all_refs()`Karthik Nayak, Jan 24, 2024
  32. 4/4 for-each-ref: avoid filtering on empty patternKarthik Nayak, Jan 24, 2024
  33. 0/4 for-each-ref: print all refs on empty string patternKarthik Nayak, Jan 29, 2024
  34. 1/4 refs: introduce `is_pseudoref()` and `is_headref()`Karthik Nayak, Jan 29, 2024
  35. Jeff KingFeb 7, 2024
  36. Karthik NayakFeb 7, 2024
  37. 2/4 refs: extract out `loose_fill_ref_dir_regular_file()`Karthik Nayak, Jan 29, 2024
  38. 3/4 refs: introduce `refs_for_each_all_refs()`Karthik Nayak, Jan 29, 2024
  39. 4/4 for-each-ref: avoid filtering on empty patternKarthik Nayak, Jan 29, 2024
  40. Phillip WoodFeb 5, 2024
  41. Patrick SteinhardtFeb 6, 2024
  42. Phillip WoodFeb 6, 2024
  43. Karthik NayakFeb 6, 2024
  44. Phillip WoodFeb 6, 2024
  45. Karthik NayakFeb 6, 2024
  46. Junio C HamanoFeb 6, 2024
  47. Junio C HamanoFeb 6, 2024
  48. Karthik NayakFeb 6, 2024
  49. Junio C HamanoFeb 6, 2024
  50. Karthik NayakFeb 7, 2024
  51. Junio C HamanoFeb 7, 2024
  52. Karthik NayakFeb 7, 2024
  53. Junio C HamanoFeb 7, 2024
  54. Karthik NayakFeb 7, 2024
  55. Patrick SteinhardtFeb 8, 2024
  56. Junio C HamanoFeb 8, 2024
  57. Patrick SteinhardtFeb 8, 2024
  58. Junio C HamanoFeb 8, 2024
  59. Patrick SteinhardtFeb 9, 2024
  60. Junio C HamanoFeb 9, 2024
  61. Karthik NayakFeb 9, 2024
  62. Patrick SteinhardtFeb 12, 2024
  63. Phillip WoodFeb 8, 2024
  64. Junio C HamanoFeb 8, 2024
  65. Patrick SteinhardtFeb 7, 2024
  66. Junio C HamanoFeb 7, 2024
  67. Junio C HamanoJan 29, 2024
  68. 0/5 for-each-ref: add '--include-root-refs' optionKarthik Nayak, Feb 11, 2024
  69. 1/5 refs: introduce `is_pseudoref()` and `is_headref()`Karthik Nayak, Feb 11, 2024
  70. Patrick SteinhardtFeb 12, 2024
  71. Junio C HamanoFeb 12, 2024
  72. Karthik NayakFeb 13, 2024
  73. Junio C HamanoFeb 13, 2024
  74. Karthik NayakFeb 14, 2024
  75. Junio C HamanoFeb 14, 2024
  76. Karthik NayakFeb 14, 2024
  77. Junio C HamanoFeb 12, 2024
  78. 2/5 refs: extract out `loose_fill_ref_dir_regular_file()`Karthik Nayak, Feb 11, 2024
  79. 3/5 refs: introduce `refs_for_each_include_root_refs()`Karthik Nayak, Feb 11, 2024
  80. 4/5 ref-filter: rename 'FILTER_REFS_ALL' to 'FILTER_REFS_REGULAR'Karthik Nayak, Feb 11, 2024
  81. 5/5 for-each-ref: add new option to include root refsKarthik Nayak, Feb 11, 2024
  82. Patrick SteinhardtFeb 22, 2024
  83. Karthik NayakFeb 22, 2024
  84. Patrick SteinhardtFeb 22, 2024
  85. 0/5 for-each-ref: add '--include-root-refs' optionKarthik Nayak, Feb 23, 2024
  86. 1/5 refs: introduce `is_pseudoref()` and `is_headref()`Karthik Nayak, Feb 23, 2024
  87. 2/5 refs: extract out `loose_fill_ref_dir_regular_file()`Karthik Nayak, Feb 23, 2024
  88. 3/5 refs: introduce `refs_for_each_include_root_refs()`Karthik Nayak, Feb 23, 2024
  89. 4/5 ref-filter: rename 'FILTER_REFS_ALL' to 'FILTER_REFS_REGULAR'Karthik Nayak, Feb 23, 2024
  90. 5/5 for-each-ref: add new option to include root refsKarthik Nayak, Feb 23, 2024
  91. Junio C HamanoFeb 23, 2024
  92. Junio C HamanoFeb 23, 2024
  93. Patrick SteinhardtFeb 27, 2024
  94. Junio C HamanoFeb 27, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.