Re: [PATCH v3 4/4] for-each-ref: avoid filtering on empty pattern
- From
Karthik Nayak <karthik.188@gmail.com>
- Date
- Feb 7, 2024, 14:10 UTC
- Message-ID
- <CAOLa=ZRcWYmEYnxh_=ykOerahZ61xaanLCj_JHHLvtrvN=Xs-w@mail.gmail.com>
- In-Reply-To
- <xmqqcyt9fdc7.fsf@gitster.g>
On Tue, Feb 6, 2024 at 11:16 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 22 quoted lines
> > Karthik Nayak <karthik.188@gmail.com> writes: > > > I think this was what the earlier discussion in the RFC series was too, > > but Phillip definitely helped consolidate the point. > > > > I'll send a new version of this patch series with `--include-root-refs` > > option and we can discuss on top of that. > > Thanks. > > By the way, I am not married to the "root refs" name, but > > - we do not want to say "all refs", as I expect refs from other > worktrees are not included, and possibly the option when > combined with explicit patterns, like refs/tags/, may further be > used to limit the output; > > - we do not want to say "pseudo refs", as I expect we would want to > show HEAD that is (unfortunately) classified outside "pseudoref" > class. >
I'm thinking "--all-ref-types" might be a good alternative. Mostly because, "--include-root-refs" seems very specific to the files backend. Also, we don't include other refs which are not HEAD | pseudorefs, but in the $GIT_DIR.