Re: [PATCH v3 4/4] for-each-ref: avoid filtering on empty pattern
On Wed, Feb 7, 2024 at 5:46 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 16 quoted lines
>
> Karthik Nayak <karthik.188@gmail.com> writes:
>
> > This is a bit of a grey area, what I mean is that we do allow users to create
> > non "refs/" prefixed refs:
> >
> > $ git update-ref foo @~1
> >
> > $ cat .git/foo
> > 2b52187cd2930931c6d34436371f470bb26eef4f
> >
> > What I mean to say is that, by saying "--include-root-refs" it seems to imply
> > that any such refs should be included too, but this simply is not the case.
>
> But isn't that a quality of implementation issue? I'd consider it a
> bug once we have and enforce the definition of what pseudorefs are.
Yeah, that makes sense. I'll use "--include-root-refs" then.
Thanks