git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 4/4] for-each-ref: avoid filtering on empty pattern

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 8, 2024, 17:53 UTC
Message-ID
<xmqq34u2onaj.fsf@gitster.g>
In-Reply-To
<ZcUOP_rWUwymhe5c@ncase>
Patrick Steinhardt <ps@pks.im> writes:
Show 15 quoted lines
> That's a different problem from the one I have right now. Let's take the
> following sequence of commands:
>
>     $ git init repo
>     Initialized empty Git repository in /tmp/repo/.git/
>     $ git -C repo commit --allow-empty --message message
>     [main (root-commit) aa5eec4] message
>     $ git -C repo update-ref ref/head/foo HEAD
>     $ ls repo/.git/ref/head/foo
>     repo/.git/ref/head/foo
>
> Now the fact that you can create "ref/head/foo" is a bug that needs to
> be fixed, no arguing there. The problem is that rectifying this problem
> with the "files" backend is easy -- you look into the repo, notice that
> there's a weird directory, and then "rm -rf" it.
OK.
Show 5 quoted lines
> But how do you learn about this ref existing with the "reftable" backend
> in the first place? You can't without looking at the binary format --
> there doesn't exist a single command that would allow you to list all
> refs unfiltered. But that is very much required in order to learn about
> misbehaviour and fix it.

I think I have been saying that it is perfectly OK if reftable backend, being newer and backed by more experience using Git, rejected any attempt to create anything under "ref/" (to avoid confusion to those who are reading from sidelines, it should allow creating "refs/mytool/" for third-party tools to store their own pointers).

Show 7 quoted lines
> As I said -- this is a bug, and I agree that it shouldn't happen. But
> bugs happen, and especially with the new reftable format I expect them
> to happen. What I look for in this context is to create the tools to fix
> problems like this, but `--include-root-refs` doesn't. A flag that
> unconditionally returns all refs, regardless of whether they have a bad
> name or not, does address the issue. Think of it of more of a debugging
> tool.

OK, "--include-all-refs" would be fine. And without bugs there should not be a difference.

Where does "all refs in this worktree" you mentioned fit in this picture? Should a bogus "ref/foo/bar" be considered to be worktree specific, or is it an incorrect attempt to create a ref that is specific to 'foo' worktree that is not the current one and be filtered out?

Previous: Patrick SteinhardtNext: Patrick Steinhardt
Message 58 of 94 in “for-each-ref: print all refs on empty string pattern”
  1. 0/5 for-each-ref: print all refs on empty string patternKarthik Nayak, Jan 19, 2024
  2. 1/5 refs: expose `is_pseudoref_syntax()`Karthik Nayak, Jan 19, 2024
  3. Junio C HamanoJan 19, 2024
  4. Karthik NayakJan 22, 2024
  5. 2/5 refs: make `is_pseudoref_syntax()` stricterKarthik Nayak, Jan 19, 2024
  6. Junio C HamanoJan 19, 2024
  7. Phillip WoodJan 22, 2024
  8. Junio C HamanoJan 22, 2024
  9. Phillip WoodJan 23, 2024
  10. Karthik NayakJan 23, 2024
  11. phillip.wood123@gmail.comJan 23, 2024
  12. Junio C HamanoJan 23, 2024
  13. Junio C HamanoJan 23, 2024
  14. Patrick SteinhardtJan 23, 2024
  15. Phillip WoodJan 23, 2024
  16. Junio C HamanoJan 23, 2024
  17. Patrick SteinhardtJan 24, 2024
  18. 3/5 refs: extract out `loose_fill_ref_dir_regular_file()`Karthik Nayak, Jan 19, 2024
  19. 4/5 refs: introduce `refs_for_each_all_refs()`Karthik Nayak, Jan 19, 2024
  20. Junio C HamanoJan 19, 2024
  21. Karthik NayakJan 22, 2024
  22. Junio C HamanoJan 22, 2024
  23. 5/5 for-each-ref: avoid filtering on empty patternKarthik Nayak, Jan 19, 2024
  24. 0/4 for-each-ref: print all refs on empty string patternKarthik Nayak, Jan 24, 2024
  25. 1/4 refs: introduce `is_pseudoref()` and `is_headref()`Karthik Nayak, Jan 24, 2024
  26. Junio C HamanoJan 24, 2024
  27. Karthik NayakJan 25, 2024
  28. Junio C HamanoJan 25, 2024
  29. Karthik NayakJan 25, 2024
  30. 2/4 refs: extract out `loose_fill_ref_dir_regular_file()`Karthik Nayak, Jan 24, 2024
  31. 3/4 refs: introduce `refs_for_each_all_refs()`Karthik Nayak, Jan 24, 2024
  32. 4/4 for-each-ref: avoid filtering on empty patternKarthik Nayak, Jan 24, 2024
  33. 0/4 for-each-ref: print all refs on empty string patternKarthik Nayak, Jan 29, 2024
  34. 1/4 refs: introduce `is_pseudoref()` and `is_headref()`Karthik Nayak, Jan 29, 2024
  35. Jeff KingFeb 7, 2024
  36. Karthik NayakFeb 7, 2024
  37. 2/4 refs: extract out `loose_fill_ref_dir_regular_file()`Karthik Nayak, Jan 29, 2024
  38. 3/4 refs: introduce `refs_for_each_all_refs()`Karthik Nayak, Jan 29, 2024
  39. 4/4 for-each-ref: avoid filtering on empty patternKarthik Nayak, Jan 29, 2024
  40. Phillip WoodFeb 5, 2024
  41. Patrick SteinhardtFeb 6, 2024
  42. Phillip WoodFeb 6, 2024
  43. Karthik NayakFeb 6, 2024
  44. Phillip WoodFeb 6, 2024
  45. Karthik NayakFeb 6, 2024
  46. Junio C HamanoFeb 6, 2024
  47. Junio C HamanoFeb 6, 2024
  48. Karthik NayakFeb 6, 2024
  49. Junio C HamanoFeb 6, 2024
  50. Karthik NayakFeb 7, 2024
  51. Junio C HamanoFeb 7, 2024
  52. Karthik NayakFeb 7, 2024
  53. Junio C HamanoFeb 7, 2024
  54. Karthik NayakFeb 7, 2024
  55. Patrick SteinhardtFeb 8, 2024
  56. Junio C HamanoFeb 8, 2024
  57. Patrick SteinhardtFeb 8, 2024
  58. Junio C HamanoFeb 8, 2024
  59. Patrick SteinhardtFeb 9, 2024
  60. Junio C HamanoFeb 9, 2024
  61. Karthik NayakFeb 9, 2024
  62. Patrick SteinhardtFeb 12, 2024
  63. Phillip WoodFeb 8, 2024
  64. Junio C HamanoFeb 8, 2024
  65. Patrick SteinhardtFeb 7, 2024
  66. Junio C HamanoFeb 7, 2024
  67. Junio C HamanoJan 29, 2024
  68. 0/5 for-each-ref: add '--include-root-refs' optionKarthik Nayak, Feb 11, 2024
  69. 1/5 refs: introduce `is_pseudoref()` and `is_headref()`Karthik Nayak, Feb 11, 2024
  70. Patrick SteinhardtFeb 12, 2024
  71. Junio C HamanoFeb 12, 2024
  72. Karthik NayakFeb 13, 2024
  73. Junio C HamanoFeb 13, 2024
  74. Karthik NayakFeb 14, 2024
  75. Junio C HamanoFeb 14, 2024
  76. Karthik NayakFeb 14, 2024
  77. Junio C HamanoFeb 12, 2024
  78. 2/5 refs: extract out `loose_fill_ref_dir_regular_file()`Karthik Nayak, Feb 11, 2024
  79. 3/5 refs: introduce `refs_for_each_include_root_refs()`Karthik Nayak, Feb 11, 2024
  80. 4/5 ref-filter: rename 'FILTER_REFS_ALL' to 'FILTER_REFS_REGULAR'Karthik Nayak, Feb 11, 2024
  81. 5/5 for-each-ref: add new option to include root refsKarthik Nayak, Feb 11, 2024
  82. Patrick SteinhardtFeb 22, 2024
  83. Karthik NayakFeb 22, 2024
  84. Patrick SteinhardtFeb 22, 2024
  85. 0/5 for-each-ref: add '--include-root-refs' optionKarthik Nayak, Feb 23, 2024
  86. 1/5 refs: introduce `is_pseudoref()` and `is_headref()`Karthik Nayak, Feb 23, 2024
  87. 2/5 refs: extract out `loose_fill_ref_dir_regular_file()`Karthik Nayak, Feb 23, 2024
  88. 3/5 refs: introduce `refs_for_each_include_root_refs()`Karthik Nayak, Feb 23, 2024
  89. 4/5 ref-filter: rename 'FILTER_REFS_ALL' to 'FILTER_REFS_REGULAR'Karthik Nayak, Feb 23, 2024
  90. 5/5 for-each-ref: add new option to include root refsKarthik Nayak, Feb 23, 2024
  91. Junio C HamanoFeb 23, 2024
  92. Junio C HamanoFeb 23, 2024
  93. Patrick SteinhardtFeb 27, 2024
  94. Junio C HamanoFeb 27, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.