Re: [PATCH 042/194] object-store: move alternates API to new alternates.h
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 9, 2018, 23:12 UTC
- Message-ID
- <xmqq4lmpvju5.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <20180206014457.GE7904@genre.crustytoothpaste.net>
"brian m. carlson" <sandals@crustytoothpaste.net> writes:
Show 13 quoted lines
>> +#include "strbuf.h"
>> +#include "sha1-array.h"
>> +
>> +struct alternates {
>> + struct alternate_object_database *list;
>> + struct alternate_object_database **tail;
>> +};
>> +#define ALTERNATES_INIT { NULL, NULL }
>
> I was surprised to find that this patch not only moves the alternates
> API to a new location, but introduces this struct. I certainly think
> the struct is a good idea, but it should probably go in a separate
> patch, or at least get a mention in the commit message.Yeah, I tend to agree that splitting it into two patches may make more sense, especially given that this is already close to 200 patch series ;-)