Re: [PATCH 076/194] push: add test showing bad interaction of replace refs and submodules
On Mon, Feb 05, 2018 at 03:55:37PM -0800, Stefan Beller wrote:
Show 30 quoted lines
> The ref subsystem has not been migrated yet to access the object store
> via passed in repository objects. As a result replace when the object store
> tries to access replace refs in a repository other than the_repository
> it produces errors:
>
> error: refs/replace/3afabef75c627b894cccc3bcae86837abc7c32fe does not point to a valid object!
>
> Add a test demonstrating this failure.
>
> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
> Signed-off-by: Stefan Beller <sbeller@google.com>
>
> squash! push: add test showing bad interaction of replace refs and submodules
>
> replace-objects: evaluate replacement refs without using the object store
>
> Pass DO_FOR_EACH_INCLUDE_BROKEN when iterating over replacement refs
> so that the iteration does not require opening the named objects from
> the object store. This avoids a dependency cycle between object access
> and replace ref iteration.
>
> Moreover the ref subsystem has not been migrated yet to access the object
> store via passed in repository objects. As a result, without this patch
> when the object store tries to access replace refs in a repository other
> than the_repository it produces errors:
>
> error: refs/replace/3afabef75c627b894cccc3bcae86837abc7c32fe does not point to a valid object!
>
> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
> Signed-off-by: Stefan Beller <sbeller@google.com>
It appears you have multiple independent commit messages here.
--
brian m. carlson / brian with sandals: Houston, Texas, US
https://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: https://keybase.io/bk2204
brian m. carlson <sandals@crustytoothpaste.net>