Re: [PATCH 025/194] object-store: allow prepare_alt_odb to handle arbitrary repositories

From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Feb 6, 2018, 01:19 UTC
Message-ID: <20180206011940.GD7904@genre.crustytoothpaste.net>
In-Reply-To: <20180205235735.216710-5-sbeller@google.com>

On Mon, Feb 05, 2018 at 03:54:46PM -0800, Stefan Beller wrote:

Show 9 quoted lines

> @@ -434,12 +433,12 @@ static int link_alt_odb_entry_the_repository(const char *entry,
>  	ent = alloc_alt_odb(pathbuf.buf);
>  
>  	/* add the alternate entry */
> -	*the_repository->objects.alt_odb_tail = ent;
> -	the_repository->objects.alt_odb_tail = &(ent->next);
> +	*r->objects.alt_odb_tail = ent;
> +	r->objects.alt_odb_tail = &(ent->next);
>  	ent->next = NULL;

I'm sure I'm missing something obvious, but it's not clear to me that this transformation is correct. Could you perhaps say a few words about why it is?

-- 
brian m. carlson / brian with sandals: Houston, Texas, US
https://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: https://keybase.io/bk2204