Re: [PATCH 038/194] pack: allow sha1_loose_object_info to handle arbitrary repositories

From: Stefan Beller <sbeller@google.com>
Date: Feb 7, 2018, 23:31 UTC
Message-ID: <CAGZ79kaVBeq_29nyvgLtjLkqZxi02RstE3ZtFOFNvKHpNu=k_w@mail.gmail.com>
In-Reply-To: <20180207143300.ce1c39ca07f6a0d64fe0e7ca@google.com>

On Wed, Feb 7, 2018 at 2:33 PM, Jonathan Tan <jonathantanmy@google.com> wrote:

Show 18 quoted lines

> On Mon,  5 Feb 2018 15:54:59 -0800
> Stefan Beller <sbeller@google.com> wrote:
>
>> From: Jonathan Nieder <jrnieder@gmail.com>
>>
>> Signed-off-by: Stefan Beller <sbeller@google.com>
>> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
>> ---
>>  sha1_file.c | 11 +++++------
>>  1 file changed, 5 insertions(+), 6 deletions(-)
>
> Thanks - I can see that this has been a lot of work, and it brings a lot
> of benefit. Among other things, this will probably allow me to remove
> the "fetch_if_missing" global variable that we need to set and reset in
> the partial clone series, replacing it with a setting in either the repo
> or the object store (and when fetching a missing object, first cloning
> the repo/store and then setting that setting, so that objects are not
> recursively fetched).

That sounds intriguing.

> If we're planning to split the series up for merging in batches (which,
> as a reviewer, I'm very much in favor of), I think this is a good
> stopping point for the first batch, so I'll stop my review here for now.

Thanks for identifying a good spot.

I'll look at this part of the series closer for a reroll, and need to make sure there are no leftovers with the #define trick.

> After these 38 patches, the net benefit is a better position of the
> packed object variables (in struct repository) and permitting the
> reading of loose objects in any repository. (Permitting the reading of
> any object in any repository, I see, will only come later in patch 74.)

which would then be a good portion for the next series.

Thanks for the review!