Re: [PATCH] config: option transfer.ipversion to set transport protocol version for network fetches

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 16, 2020, 22:52 UTC
Message-ID: <xmqq4knxuyfz.fsf@gitster.c.googlers.com>
In-Reply-To: <xmqqbli5uyj4.fsf@gitster.c.googlers.com>

Junio C Hamano <gitster@pobox.com> writes:

Show 15 quoted lines

> Jeff King <peff@peff.net> writes:
>
>> Adding a command-line option for "all" is a good idea, but will probably
>> mean needing to add the "unset" sentinel value I mentioned in the other
>> email.
>
> Sorry, I do not quite follow.  I thought that assigning the
> (misnamed --- see other mail) ALL to the "family" variable would be
> sufficient?
>
>     enum transport_family {
>             TRANSPORT_FAMILY_ALL = 0,
>             TRANSPORT_FAMILY_IPV4,
>             TRANSPORT_FAMILY_IPV6
>     };

Ah, I see. We want a way to tell "nobody has set it from the command line or the config" and "we were explicitly told to accept any" apart.

But wouldn't the usual "read config first and then override from the command line" handle that without "not yet set" value? I thought we by default accept any.