Re: [PATCH] Pass --ipv4 and --ipv6 options to sub-fetches when fetching multiple remotes and submodules
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 15, 2020, 21:19 UTC
- Message-ID
- <xmqqeen2zqk0.fsf@gitster.c.googlers.com>
- In-Reply-To
- <20200915115407.GA31786@pflmari>
Alex Riesen <alexander.riesen@cetitec.com> writes:
Show 7 quoted lines
> The options indicate user intent for the whole fetch operation, and > ignoring them in sub-fetches is quite unexpected when, for instance, > it is intended to limit all of the communication to a specific transport > protocol for some reason. > > Signed-off-by: Alex Riesen <alexander.riesen@cetitec.com> > ---
To avoid an overlong title and conform to project convention (aka "easier to read 'git shortlog --no-merges' output), I shortened the title and tweaked the text a bit to compensate for the change.
Thanks.
-- >8 -- From: Alex Riesen <alexander.riesen@cetitec.com> Date: Tue, 15 Sep 2020 13:54:07 +0200 Subject: [PATCH] fetch: pass --ipv4 and --ipv6 options to sub-fetches
The options indicate user intent for the whole fetch operation, and ignoring them in sub-fetches (i.e. "--all" and recursive fetching of submodules) is quite unexpected when, for instance, it is intended to limit all of the communication to a specific transport protocol for some reason.
Signed-off-by: Alex Riesen <alexander.riesen@cetitec.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> --- builtin/fetch.c | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/builtin/fetch.c b/builtin/fetch.c index 82ac4be8a5..447d28ac29 100644 --- a/builtin/fetch.c +++ b/builtin/fetch.c @@ -1531,6 +1531,10 @@ static void add_options_to_argv(struct argv_array *argv) argv_array_push(argv, "-v"); else if (verbosity < 0) argv_array_push(argv, "-q"); + if (family == TRANSPORT_FAMILY_IPV4) + argv_array_push(argv, "--ipv4"); + else if (family == TRANSPORT_FAMILY_IPV6) + argv_array_push(argv, "--ipv6"); }
-- 2.28.0-618-g53f972bf7d