Re: [PATCH v7 00/17] propose config-based hooks (part I)
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 25, 2021, 19:50 UTC
- Message-ID
- <xmqq4ki0udu4.fsf@gitster.g>
- In-Reply-To
- <xmqqlfbmi99f.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
Show 16 quoted lines
> Josh Steadmon <steadmon@google.com> writes: > >>> The topic branch has a lot more commits than these 17; I am >>> wondering if the reviewed-by applies only to the bottom 17, or as >>> the whole? I recall that the upper half was expecting at least some >>> documentation updates. >>> >>> Thanks. >> >> Just to these 17, sorry for being unclear. > > Thanks for reading them through. > > I am tempted to say we should merge these "mechanism" part down to > 'next', hoping that the "rewrite existing ones using the new > mechansim" part can follow soon.
I said this on Feb 17th, but since then I think I saw you answer "I'll do that" in responses to JTan's reviews in the past few days (e.g. <YC7o2rUQOEdiMdqh@google.com>). Would I regret if I merge the topic down to 'next' today?
Thanks.