Re: [PATCH v7 06/17] hook: implement hookcmd.<name>.skip

From: Jonathan Tan <jonathantanmy@google.com>
Date: Jan 31, 2021, 03:40 UTC
Message-ID: <20210131034030.1025259-1-jonathantanmy@google.com>
In-Reply-To: <20201222000220.1491091-7-emilyshaffer@google.com>

> If a user wants a specific repo to skip execution of a hook which is set
> at a global or system level, they can now do so by specifying 'skip' in
> their repo config:

Usually the present tense describes the situation before the commit, so maybe s/they can now do so/they will be able to do so/.

> -static void append_or_move_hook(struct list_head *head, const char *command)
> +static struct hook* find_hook_by_command(struct list_head *head, const char *command)

"* " -> " *"

[snip tests]

For the tests, I thought of the case in which we skip a hookcmd that was never specified as a hook, but that's probably not very useful.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.