Re: [PATCH 15/17] hook: provide stdin by string_list or callback
- From
SZEDER Gábor <szeder.dev@gmail.com>
- Date
- Dec 8, 2020, 21:09 UTC
- Message-ID
- <20201208210925.GI8396@szeder.dev>
- In-Reply-To
- <20201205014607.1464119-16-emilyshaffer@google.com>
On Fri, Dec 04, 2020 at 05:46:05PM -0800, Emily Shaffer wrote:
Show 9 quoted lines
> diff --git a/hook.c b/hook.c
> index f0c052d847..fbb49f241d 100644
> --- a/hook.c
> +++ b/hook.c
> @@ -9,6 +9,8 @@ void free_hook(struct hook *ptr)
> {
> if (ptr) {
> strbuf_release(&ptr->command);
> + if (ptr->feed_pipe_cb_data)Coccinelle suggests to drop this condition, because free() can handle a NULL pointer just fine.
> + free(ptr->feed_pipe_cb_data); > free(ptr); > } > }