Re: [PATCH v8 0/3] Makefile: link osxkeychain helper against Rust

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 8, 2026, 20:16 UTC
Message-ID: <xmqq4ii9teym.fsf@gitster.g>
In-Reply-To: <pull.2288.v8.git.git.1783480879.gitgitgadget@gmail.com>

"Shardul Natu via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 6 quoted lines

> Changes since v7:
>
>  * Added inclusion of ../config.mak.uname to the top of contrib/Makefile in
>    the canonical order. This guarantees that $(uname_S) is correctly defined
>    on the shell, preventing the OS_CONTRIB additions from being silently
>    ignored.

This round of patches looked good to me (even though I am not a macOS user, so my review only goes on the surface without actual testing).

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.