From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 08 Jul 2026 20:16:01 GMT
Subject: Re: [PATCH v8 0/3] Makefile: link osxkeychain helper against Rust
Message-ID: <xmqq4ii9teym.fsf@gitster.g>
In-Reply-To: <pull.2288.v8.git.git.1783480879.gitgitgadget@gmail.com>

"Shardul Natu via GitGitGadget" <gitgitgadget@gmail.com> writes:

> Changes since v7:
>
>  * Added inclusion of ../config.mak.uname to the top of contrib/Makefile in
>    the canonical order. This guarantees that $(uname_S) is correctly defined
>    on the shell, preventing the OS_CONTRIB additions from being silently
>    ignored.

This round of patches looked good to me (even though I am not a
macOS user, so my review only goes on the surface without actual
testing).