Re: [PATCH v7 3/3] contrib: wire up osxkeychain in contrib/Makefile on macOS

From: Shardul Natu <snatu@google.com>
Date: Jul 8, 2026, 03:15 UTC
Message-ID: <20260708031552.157939-1-snatu@google.com>
In-Reply-To: <xmqqmrw3aoas.fsf@gitster.g>

Show 10 quoted lines

> Is $(uname_S) defined here at this point with only the above two
> includes?  Don't you need to include ../config.mak.uname as well?
> 
> The top-level Makefile does this:
> 
>         include config.mak.uname
>         -include config.mak.autogen
>         -include config.mak
> 
> and so should this one, I think, in exactly the same order.

Ah, yes. I have updated the include sequence in contrib/Makefile to:
  include ../config.mak.uname
  -include ../config.mak.autogen
  -include ../config.mak

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.