Re: [PATCH v4 0/2] Makefile: link osxkeychain helper against Rust
> This was addressing Patrick's comment, which was already done in v3;
> hopefully that is now settled?
Sorry, updated the description of the PR!
> It is a mystery what the third bullet point was ;-)
Remnant of thoughts! Removed!!
Thank you,
Shardul
On Sat, Jul 4, 2026 at 9:08 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 24 quoted lines
>
> "Shardul Natu via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
> > Changes since v2:
> >
> > * Split the original combined commit into a two-patch series to separate
> > prerequisite bug fixes from Universal Binary features.
>
> This was addressing Patrick's comment, which was already done in v3;
> hopefully that is now settled?
>
> > * Added $(call mkdir_p_parent_template) prior to invoking lipo to guarantee
> > that parent target directories exist.
>
> Obviously correct ;-).
>
> > *
> >
>
> It is a mystery what the third bullet point was ;-)
>
> The changes relative to v3 (which I looked at) look good now.
>
> Thanks.