Re: [PATCH v4 1/2] Makefile: add $(RUST_LIB) prerequisite to osxkeychain
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Jul 6, 2026, 10:49 UTC
- Message-ID
- <akuIO-uOy3KhqIAE@pks.im>
- In-Reply-To
- <41de7d391ac00c70bfa981d20ed9df22dbdf7ace.1783188355.git.gitgitgadget@gmail.com>
On Sat, Jul 04, 2026 at 06:05:54PM +0000, Shardul Natu via GitGitGadget wrote:
Show 14 quoted lines
> From: Shardul Natu <snatu@google.com> > diff --git a/Makefile b/Makefile > index 1f3f099f5c..7db38ecce9 100644 > --- a/Makefile > +++ b/Makefile > @@ -4074,7 +4078,8 @@ $(LIBGIT_HIDDEN_EXPORT): $(LIBGIT_PARTIAL_EXPORT) > contrib/libgit-sys/libgitpub.a: $(LIBGIT_HIDDEN_EXPORT) > $(AR) $(ARFLAGS) $@ $^ > > -contrib/credential/osxkeychain/git-credential-osxkeychain: contrib/credential/osxkeychain/git-credential-osxkeychain.o $(LIB_FILE) GIT-LDFLAGS > +# When Rust is enabled, git-credential-osxkeychain depends on Rust symbols in $(RUST_LIB) > +contrib/credential/osxkeychain/git-credential-osxkeychain: contrib/credential/osxkeychain/git-credential-osxkeychain.o $(LIB_FILE) $(RUST_LIB) GIT-LDFLAGS > $(QUIET_LINK)$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) \ > $(filter %.o,$^) $(LIBS) -framework Security -framework CoreFoundation
I was wondering why no other target declares an explicit dependency on RUST_LIB. As it turns out, all the other targets that link "$(LIBS)" all already depend on "$(GITLIBS)", which includes both "$(LIB_FILE)" and "$(RUST_LIB)". So shouldn't we also depend depend on "$(GITLIBS)" here instead of on either of the other two variables?
Patrick