Re: [PATCH 5/4] sq_quote_argv: drop maxlen parameter
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 12, 2018, 23:20 UTC
- Message-ID
- <xmqq373awtns.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <20180112133810.GA8290@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 9 quoted lines
> No caller passes anything but "0" for this parameter, which > requests that the function ignore it completely. In fact, in > all of history there was only one such caller, and it went > away in 7f51f8bc2b (alias: use run_command api to execute > aliases, 2011-01-07). > > Signed-off-by: Jeff King <peff@peff.net> > --- > Just a cleanup, though it touches the caller you just added, too.
Yup. This is a good change in the longer term. I needed an evil merge for a stalled topic in 'pu' to adjust a couple of new callers, though ;-)..