Re: [PATCH] run-command.c: print env vars when GIT_TRACE is set

From: Brandon Williams <bmwill@google.com>
Date: Jan 10, 2018, 19:26 UTC
Message-ID: <20180110192606.GB53941@google.com>
In-Reply-To: <CAGZ79ka0mhPy776fRYtvnaqd5P1dwvuaeONozEWpaJVZxSneiA@mail.gmail.com>

On 01/10, Stefan Beller wrote:

Show 10 quoted lines

> On Wed, Jan 10, 2018 at 10:09 AM, Brandon Williams <bmwill@google.com> wrote:
> > At first when i read this I was under the impression that the whole
> > environment was going to be printed out...but i now realize that this
> > tracing  will only print out the delta's or the additions to the
> > environment that the child will see.  Maybe this should be called out
> > more clearly in the commit message?
> 
> It only adds newly set variables, I wonder why deletions are noisy?
> I could not find an example of a removal of environment variables
> specific to submodules that would be noisy.

Deletions are noisy because we append local_repo_env anytime we kick off a child process (ok maybe not all the time, but a lot of the time) which is just a list of ~15 deletions.

-- 
Brandon Williams