Re: [PATCH v2] run-command.c: print env vars when GIT_TRACE is set

From: Duy Nguyen <pclouds@gmail.com>
Date: Jan 11, 2018, 11:25 UTC
Message-ID: <CACsJy8BpFiNTQKLU2g=4Fat2gC1R0OcMteqcZx0ubg5ChNmKgw@mail.gmail.com>
In-Reply-To: <20180111094712.2551-1-pclouds@gmail.com>

On Thu, Jan 11, 2018 at 4:47 PM, Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:

>  Though, Stefan, while i'm not opposed to trace every single setting
>  in child_process, including variable deletion, cwd and even more, it

Another thing I forgot to add, s/ and even more/, redirection&/. At some point I think I was checking the git-pack-objects command from GIT_TRACE and didn't realize it was taking input from stdin (I was naive :D). At least on linux we could even take advantage of /proc/<pid>/fd to show path names and stuff in addition to plain file descriptors.

Show 5 quoted lines

>  may be not that often needed for a "casual" developer.
>
>  I suggest we have something like $GIT_TRACE_EXEC instead that could
>  be super verbose when we need it and leave $GIT_TRACE with a
>  reasonable subset.

-- 
Duy